Merge the 3 different closure nodes into a single node.

Merge the 3 different closure nodes into a single node.
Committed: https://code.google.com/p/dart/source/detail?r=485

[siva, 2011-10-17 19:03:39]

LGTM

http://codereview.chromium.org/8294013/diff/1/runtime/vm/ast.h
File runtime/vm/ast.h (right):

http://codereview.chromium.org/8294013/diff/1/runtime/vm/ast.h#newcode375
runtime/vm/ast.h:375: !function.IsImplicitInstanceClosureFunction());
I am wondering if this would be more readable as:
ASSERT((function.IsImplicitInstanceClosureFunction() && receiver != NULL &&
scope_ == NULL) ||
(function.IsNonImplicitClosureFunction && scope_ != NULL && receiver == NULL) ||
(function.IsImplicitStaticClosureFunction() && receiver == NULL && scope_ ==
NULL))

[regis, 2011-10-17 20:19:28]

Thanks!

http://codereview.chromium.org/8294013/diff/1/runtime/vm/ast.h
File runtime/vm/ast.h (right):

http://codereview.chromium.org/8294013/diff/1/runtime/vm/ast.h#newcode375
runtime/vm/ast.h:375: !function.IsImplicitInstanceClosureFunction());
On 2011/10/17 19:03:39, asiva wrote:
> I am wondering if this would be more readable as:
> ASSERT((function.IsImplicitInstanceClosureFunction() && receiver != NULL &&
> scope_ == NULL) ||
> (function.IsNonImplicitClosureFunction && scope_ != NULL && receiver == NULL)
||
> (function.IsImplicitStaticClosureFunction() && receiver == NULL && scope_ ==
> NULL))

Done.