Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8294005: Rename class AssertError to AssertionError in the VM (fix issue 119). (Closed)

Created:
9 years, 2 months ago by regis
Modified:
9 years, 2 months ago
Reviewers:
John Lenz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename class AssertError to AssertionError in the VM (fix issue 119). Move VM specific tests to the correct tests directory. Enable asserts in the VM when type checks are enabled. Committed: https://code.google.com/p/dart/source/detail?r=460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -81 lines) Patch
M runtime/lib/error.cc View 2 chunks +19 lines, -15 lines 0 comments Download
M runtime/lib/error.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/language/src/AssertTest.dart View 1 chunk +0 lines, -54 lines 0 comments Download
A + tests/standalone/src/AssertTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
9 years, 2 months ago (2011-10-14 21:56:37 UTC) #1
John Lenz
9 years, 2 months ago (2011-10-14 22:00:18 UTC) #2
On 2011/10/14 21:56:37, regis wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698