Set type argument vector at compile time in type of closure parameters; this

Set type argument vector at compile time in type of closure parameters; this
require the introduction of a signature type cached in signature functions.
Support printing of the name of an instantiated signature type, e.g. print
'(int) => int' instead of '<T>(T) => T<int>'.
Avoid cycles when printing the name of illegal types during error reporting by
checking that the type is not being finalized.
Committed: https://code.google.com/p/dart/source/detail?r=479

[siva, 2011-10-17 18:36:58]

LGTM

http://codereview.chromium.org/8289027/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8289027/diff/1/runtime/vm/object.cc#newcode707
runtime/vm/object.cc:707: const intptr_t num_type_params = NumTypeParameters();
Should we add a num_type_params check? would avoid 4 handle creations.

if (num_type_params > 0) {
  ....
  ...
  ...
  ...
  for (int i = 0;.....) {
  }
}

Also what does TypeArguments::NewTypeArray(0) return?

[regis, 2011-10-17 19:02:47]

Thanks!

http://codereview.chromium.org/8289027/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8289027/diff/1/runtime/vm/object.cc#newcode707
runtime/vm/object.cc:707: const intptr_t num_type_params = NumTypeParameters();
On 2011/10/17 18:36:59, asiva wrote:
> Should we add a num_type_params check? would avoid 4 handle creations.
> 
> if (num_type_params > 0) {
>   ....
>   ...
>   ...
>   ...
>   for (int i = 0;.....) {
>   }
> }
> 
> Also what does TypeArguments::NewTypeArray(0) return?

Good point. I actually can replace the test IsParameterized() by num_type_params
> 0.
Is it OK to leave the type argument vector as null if the class has no type
parameters on its own. Type finalization will extend the vector with the
arguments of the base class if necessary.