Add a command-line option for generating source maps.

Add a command-line option for generating source maps.
Committed: https://code.google.com/p/dart/source/detail?r=486

[John Lenz, 2011-10-14 15:00:32]

On 2011/10/13 20:52:47, John Lenz wrote:

ping

[John Lenz, 2011-10-17 16:11:15]

On 2011/10/14 15:00:32, John Lenz wrote:
> On 2011/10/13 20:52:47, John Lenz wrote:
> 
> ping

ping

[zundel, 2011-10-17 17:28:46]

http://codereview.chromium.org/8287001/diff/3001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

http://codereview.chromium.org/8287001/diff/3001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:69: @Option(name
= "--generate-source-maps",
vm uses underscores instead of dashes to separate words in options.  Since their
arg parsing mechanism doesn't actually have a choice in this, I'd like us to
switch to that now that we are post-technology-preview.

http://codereview.chromium.org/8287001/diff/3001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/CompilerTestCase.java (right):

http://codereview.chromium.org/8287001/diff/3001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/CompilerTestCase.java:193: * Allow
tests to overrider the configuration used.
overrider --> override

[John Lenz, 2011-10-17 18:38:35]

http://codereview.chromium.org/8287001/diff/3001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

http://codereview.chromium.org/8287001/diff/3001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:69: @Option(name
= "--generate-source-maps",
On 2011/10/17 17:28:46, zundel wrote:
> vm uses underscores instead of dashes to separate words in options.  Since
their
> arg parsing mechanism doesn't actually have a choice in this, I'd like us to
> switch to that now that we are post-technology-preview.

Done.

http://codereview.chromium.org/8287001/diff/3001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/CompilerTestCase.java (right):

http://codereview.chromium.org/8287001/diff/3001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/CompilerTestCase.java:193: * Allow
tests to overrider the configuration used.
On 2011/10/17 17:28:46, zundel wrote:
> overrider --> override

Done.

[zundel, 2011-10-17 19:05:24]

lgtm

[mmendez, 2011-10-17 19:34:24]

LGTM - lets have people opt in if they want source maps.

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java
(right):

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java:435: if
(this.generateSourceMap(context)) {
Nit: don't need this qualifier.

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/runner/DartRunner.java (right):

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
compiler/java/com/google/dart/runner/DartRunner.java:377: Reader mr =
provider.getArtifactReader(app, "", backend.getSourceMapExtension());
This follows the existing pattern but, CharStreams.toString can throw in which
case we'd leak the reader.  Probably only an issue if running in batch mode.

Feel free to address in a separate CL if that is easier.

[John Lenz, 2011-10-17 20:06:29]

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java
(right):

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/backend/js/ClosureJsBackend.java:435: if
(this.generateSourceMap(context)) {
On 2011/10/17 19:34:24, mmendez wrote:
> Nit: don't need this qualifier.

Done.

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/runner/DartRunner.java (right):

http://codereview.chromium.org/8287001/diff/6002/compiler/java/com/google/dar...
compiler/java/com/google/dart/runner/DartRunner.java:377: Reader mr =
provider.getArtifactReader(app, "", backend.getSourceMapExtension());
On 2011/10/17 19:34:24, mmendez wrote:
> This follows the existing pattern but, CharStreams.toString can throw in which
> case we'd leak the reader.  Probably only an issue if running in batch mode.
> 
> Feel free to address in a separate CL if that is easier.

Easy change. Done.