Changes "is" and equality checks to strictly check for primitive types, fix a couple of

Changes "is" and equality checks to strictly check for primitive types, fix a couple of
places we were converting primitives to Object types by "this" coersions.

Fixes issue 79.
Committed: https://code.google.com/p/dart/source/detail?r=456

[John Lenz, 2011-10-14 15:54:58]

On 2011/10/13 17:38:22, John Lenz wrote:

Florian, would you prefer someone else look at the lib changes?

[floitsch, 2011-10-14 20:20:44]

LGTM!
sorry for the delay.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
File compiler/lib/implementation/bool.dart (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
compiler/lib/implementation/bool.dart:22: get dynamic() { return toBool(); }
good catch.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
File compiler/lib/implementation/bool.js (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
compiler/lib/implementation/bool.js:5: function
native_BoolImplementation_EQ(other) {
maybe for another CL, but ideally we should never end up here.
operator$EQ should simply say:
if (typeof x == "boolean") return x === other;

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
compiler/lib/implementation/bool.js:9: function
native_BoolImplementation_toString() {
Same is true here. Since we already need to intercept 'toString', to support
null.toString, we should intercept booleans there too.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/num...
File compiler/lib/implementation/number.js (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/num...
compiler/lib/implementation/number.js:87: return typeof other == 'number' &&
this == other;
Same as for booleans: operator$EQ should intercept and we should never arrive
here.
(again: another CL is fine).

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/str...
File compiler/lib/implementation/string.dart (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/str...
compiler/lib/implementation/string.dart:148: // call "toString" to coerse the
"this" back to a primitive string
Call ... coerce ... string. (finish with dot).

[John Lenz, 2011-10-14 21:26:40]

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
File compiler/lib/implementation/bool.js (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
compiler/lib/implementation/bool.js:5: function
native_BoolImplementation_EQ(other) {
On 2011/10/14 20:20:44, floitsch wrote:
> maybe for another CL, but ideally we should never end up here.
> operator$EQ should simply say:
> if (typeof x == "boolean") return x === other;

yes. I leave that for another CL. After we have golem back up and running.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/boo...
compiler/lib/implementation/bool.js:9: function
native_BoolImplementation_toString() {
On 2011/10/14 20:20:44, floitsch wrote:
> Same is true here. Since we already need to intercept 'toString', to support
> null.toString, we should intercept booleans there too.

true, there is less need for this to be special cased, I think.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/num...
File compiler/lib/implementation/number.js (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/num...
compiler/lib/implementation/number.js:87: return typeof other == 'number' &&
this == other;
On 2011/10/14 20:20:44, floitsch wrote:
> Same as for booleans: operator$EQ should intercept and we should never arrive
> here.
> (again: another CL is fine).

It is already special cased in EQ$operator, but I'll leave this for now.

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/str...
File compiler/lib/implementation/string.dart (right):

http://codereview.chromium.org/8286001/diff/1/compiler/lib/implementation/str...
compiler/lib/implementation/string.dart:148: // call "toString" to coerse the
"this" back to a primitive string
On 2011/10/14 20:20:44, floitsch wrote:
> Call ... coerce ... string. (finish with dot).

Done.