Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 8285004: Ground work for addition to new listener api (Closed)

Created:
9 years, 2 months ago by codefu
Modified:
9 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ground work for addition to new listener api Committed: https://code.google.com/p/dart/source/detail?r=438

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompilerListener.java View 1 2 chunks +9 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompilerMainContext.java View 2 chunks +6 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DefaultDartCompilerListener.java View 2 chunks +6 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DeltaAnalyzer.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/testing/TestCompilerContext.java View 2 chunks +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/CompilerTestCase.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/DartCompilerListenerTest.java View 2 chunks +6 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/backend/common/TypeHeuristicImplementationTest.java View 1 chunk +5 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java View 2 chunks +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerBench.java View 1 chunk +4 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java View 2 chunks +5 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/corelib/SharedTestCase.java View 2 chunks +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/CompilerListener.java View 2 chunks +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/compiler/SilentDartCompilerListener.java View 2 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeSnippetParsingUtil.java View 2 chunks +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerUtilities.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/compiler/TestCompilerListener.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Brian Wilkerson
I didn't see anywhere where you were testing to see whether the right compilation units ...
9 years, 2 months ago (2011-10-13 22:17:28 UTC) #1
Brian Wilkerson
9 years, 2 months ago (2011-10-14 13:22:31 UTC) #2
Aside from the lack of documentation and the lack of tests for the new listener
method, both of which can be addressed later if need be, it LGTM.

http://codereview.chromium.org/8285004/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompilerListener.java (right):

http://codereview.chromium.org/8285004/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompilerListener.java:28: public
abstract void unitCompiled(DartUnit unit);
It would be nice if all of the methods in this interface were well documented,
both with guarantees from the compiler as well as requirements on the
implementor.

Powered by Google App Engine
This is Rietveld 408576698