Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8284001: Libraries cannot source themselves anymore. (Closed)

Created:
9 years, 2 months ago by fmalita_google_do_not_use
Modified:
9 years, 2 months ago
Reviewers:
pdr, Kelly Norton
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Libraries cannot source themselves anymore. After https://code.google.com/p/dart/source/detail?r=383, LibraryFromSources fails the library self-include check. R=knorton@google.com,pdr@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=405

Patch Set 1 #

Patch Set 2 : Avoid generating an extra #source directive in getSourceReader(). #

Total comments: 2

Patch Set 3 : Cleanup. #

Patch Set 4 : Minor cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M client/fling/src/java/core/com/google/dart/LibraryFromSources.java View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
fmalita_google_do_not_use
9 years, 2 months ago (2011-10-13 17:02:42 UTC) #1
fmalita_google_do_not_use
Updated to avoid adding an extra #source entry in getSourceReader().
9 years, 2 months ago (2011-10-13 17:29:41 UTC) #2
Kelly Norton
http://codereview.chromium.org/8284001/diff/3001/client/fling/src/java/core/com/google/dart/LibraryFromSources.java File client/fling/src/java/core/com/google/dart/LibraryFromSources.java (right): http://codereview.chromium.org/8284001/diff/3001/client/fling/src/java/core/com/google/dart/LibraryFromSources.java#newcode66 client/fling/src/java/core/com/google/dart/LibraryFromSources.java:66: return new DartSourceString(name, ""); Shouldn't you be able to ...
9 years, 2 months ago (2011-10-13 17:37:46 UTC) #3
fmalita_google_do_not_use
http://codereview.chromium.org/8284001/diff/3001/client/fling/src/java/core/com/google/dart/LibraryFromSources.java File client/fling/src/java/core/com/google/dart/LibraryFromSources.java (right): http://codereview.chromium.org/8284001/diff/3001/client/fling/src/java/core/com/google/dart/LibraryFromSources.java#newcode66 client/fling/src/java/core/com/google/dart/LibraryFromSources.java:66: return new DartSourceString(name, ""); On 2011/10/13 17:37:46, Kelly Norton ...
9 years, 2 months ago (2011-10-13 17:57:42 UTC) #4
Kelly Norton
lgtm
9 years, 2 months ago (2011-10-13 17:58:55 UTC) #5
fmalita_google_do_not_use
9 years, 2 months ago (2011-10-13 18:15:34 UTC) #6 
r405

Powered by Google App Engine
This is Rietveld 408576698