Make sure we cleanup what was generated by the architecture.

Make sure we cleanup what was generated by the architecture.
Committed: https://code.google.com/p/dart/source/detail?r=440

[zundel, 2011-10-14 13:57:22]

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py#newc...
tools/testing/test_case.py:159: if not self.context.keep_temporary_files:
What do you think about moving this method to TestCase.Cleanup and sharing code
with StandardTestCase.

We can test for the presence of run_arch with:

if run_arch in self and not self.context.keep_temporary_files:
 ...

[ngeoffray, 2011-10-14 14:08:39]

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py#newc...
tools/testing/test_case.py:159: if not self.context.keep_temporary_files:
On 2011/10/14 13:57:22, zundel wrote:
> What do you think about moving this method to TestCase.Cleanup and sharing
code
> with StandardTestCase.
> 
> We can test for the presence of run_arch with:
> 
> if run_arch in self and not self.context.keep_temporary_files:
>  ...

I'd rather not touch TestCase. The run_arch kind of looks like detail to me,
which TestCase should not deal with. Would you prefer an class in between
TestCase and all the other test cases?

[zundel, 2011-10-14 14:13:02]

lgtm

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py#newc...
tools/testing/test_case.py:159: if not self.context.keep_temporary_files:
On 2011/10/14 14:08:39, ngeoffray wrote:
> On 2011/10/14 13:57:22, zundel wrote:
> > What do you think about moving this method to TestCase.Cleanup and sharing
> code
> > with StandardTestCase.
> > 
> > We can test for the presence of run_arch with:
> > 
> > if run_arch in self and not self.context.keep_temporary_files:
> >  ...
> 
> I'd rather not touch TestCase. The run_arch kind of looks like detail to me,
> which TestCase should not deal with. Would you prefer an class in between
> TestCase and all the other test cases?

No, I don't think adding a class in between would be much good just for this one
case.

[ngeoffray, 2011-10-14 14:25:06]

Thanks Eric!

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8283033/diff/1/tools/testing/test_case.py#newc...
tools/testing/test_case.py:159: if not self.context.keep_temporary_files:
On 2011/10/14 14:13:02, zundel wrote:
> On 2011/10/14 14:08:39, ngeoffray wrote:
> > On 2011/10/14 13:57:22, zundel wrote:
> > > What do you think about moving this method to TestCase.Cleanup and sharing
> > code
> > > with StandardTestCase.
> > > 
> > > We can test for the presence of run_arch with:
> > > 
> > > if run_arch in self and not self.context.keep_temporary_files:
> > >  ...
> > 
> > I'd rather not touch TestCase. The run_arch kind of looks like detail to me,
> > which TestCase should not deal with. Would you prefer an class in between
> > TestCase and all the other test cases?
> 
> No, I don't think adding a class in between would be much good just for this
one
> case. 
> 
> 

OK, committing then. If it turns out there are too many things that can be
shared in TestCase, we can reconsider.