Add exists, create and delete to directory implementation on Linux and Mac.

Add exists, create and delete to directory implementation on Linux and Mac.

All of the directory implementations on Linux and Mac are identical
and uncontroversial. Join the implementations in directory_posix for
now. I will split it into the two files again if it becomes necessary.

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=432

[Mads Ager (google), 2011-10-14 10:49:31]

Synchronous for now.

[Søren Gjesse, 2011-10-14 11:44:13]

lgtm

I suppose you will add some tests later...

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory.cc#newcode43
runtime/bin/directory.cc:43: bool success =
Directory::Exists(DartUtils::GetStringValue(path), &exists);
How about returning an enum Yes/No/Don't know instead of two bools?

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory_impl.dart...
runtime/bin/directory_impl.dart:43: int exists = _exists(_path);
Should we provide errno/strerrno information here as we do for process creation?

[Mads Ager (google), 2011-10-14 12:22:53]

I implemented for Windows and added a simple test. I will add a recursive
directory listing test soon by using the new create/exists/delete calls to build
a structure, list it, then delete it.

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory.cc#newcode43
runtime/bin/directory.cc:43: bool success =
Directory::Exists(DartUtils::GetStringValue(path), &exists);
On 2011/10/14 11:44:14, Søren Gjesse wrote:
> How about returning an enum Yes/No/Don't know instead of two bools?

Done.

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/8277033/diff/1/runtime/bin/directory_impl.dart...
runtime/bin/directory_impl.dart:43: int exists = _exists(_path);
On 2011/10/14 11:44:14, Søren Gjesse wrote:
> Should we provide errno/strerrno information here as we do for process
creation?

Yes, we should. Added a TODO to all of the new methods here and will deal with
it in a week when I'm back from vacation.

[Søren Gjesse, 2011-10-14 12:30:57]

lgtm