If we run into a "super()" in a function body, report and error and parse it

If we run into a "super()" in a function body, report and error and parse it
as a literal.

R=jat@google.com,messick@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=414

[jat, 2011-10-13 19:30:33]

LGTM

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2107:
superExpression = parseLiteral();
Why literal here?  I think substituting a synthetic error node is probably more
useful.

[codefu, 2011-10-13 19:32:23]

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2107:
superExpression = parseLiteral();
On 2011/10/13 19:30:33, jat wrote:
> Why literal here?  I think substituting a synthetic error node is probably
more
> useful.

There's already an error reported and it looked like a function call.  Synthetic
returns [error: super] and didn't include the (...params...).  If you'd like, I
can try to change it.

[jat, 2011-10-13 19:43:43]

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2107:
superExpression = parseLiteral();
On 2011/10/13 19:32:23, codefu wrote:
> On 2011/10/13 19:30:33, jat wrote:
> > Why literal here?  I think substituting a synthetic error node is probably
> more
> > useful.
> 
> There's already an error reported and it looked like a function call. 
Synthetic
> returns [error: super] and didn't include the (...params...).  If you'd like,
I
> can try to change it.

We already tried parseAssignableSelector and it failed, so it isn't going to be
treated like a function call.  I suspect you want to eat tokens to a statement
terminator and insert a synthetic error statement in the AST.

[codefu, 2011-10-13 20:17:44]

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2107:
superExpression = parseLiteral();
On 2011/10/13 19:43:43, jat wrote:
> On 2011/10/13 19:32:23, codefu wrote:
> > On 2011/10/13 19:30:33, jat wrote:
> > > Why literal here?  I think substituting a synthetic error node is probably
> > more
> > > useful.
> > 
> > There's already an error reported and it looked like a function call. 
> Synthetic
> > returns [error: super] and didn't include the (...params...).  If you'd
like,
> I
> > can try to change it.
> 
> We already tried parseAssignableSelector and it failed, so it isn't going to
be
> treated like a function call.  I suspect you want to eat tokens to a statement
> terminator and insert a synthetic error statement in the AST.

I just updated the patch to only be a one-line change, making
parseAssignableSelector() return the passed in expression if there's an error. 
This leaves the target as the DartSuperExpression() instead of null, and
consumes the function arguments.

[jat, 2011-10-13 20:24:08]

LGTM

http://codereview.chromium.org/8277013/diff/4002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/4002/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2301: expression =
receiver;
You should get one of the IDE guys to sign off on this.

[codefu, 2011-10-13 20:29:16]

http://codereview.chromium.org/8277013/diff/4002/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8277013/diff/4002/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2301: expression =
receiver;
On 2011/10/13 20:24:08, jat wrote:
> You should get one of the IDE guys to sign off on this.

Steve is on the reviewers list.

[Brian Wilkerson, 2011-10-13 20:41:30]

Steve is on vacation, but it LGTM.