Issue 8276005: Implement List.getRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8276005: Implement List.getRange. (Closed)

Created:
9 years, 2 months ago by ngeoffray

Modified:
9 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Implement List.getRange. Committed: https://code.google.com/p/dart/source/detail?r=403

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -4 lines)			Patch
M	compiler/lib/implementation/array.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	compiler/lib/implementation/arrays.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/lib/array.dart	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	runtime/lib/arrays.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	tests/corelib/src/ListGetRangeTest.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. http://codereview.chromium.org/8276005/diff/1/compiler/lib/implementation/array.dart File compiler/lib/implementation/array.dart (right): http://codereview.chromium.org/8276005/diff/1/compiler/lib/implementation/array.dart#newcode194 compiler/lib/implementation/array.dart:194: return new List<T>.fromList(this, start, start + length); We ...

9 years, 2 months ago (2011-10-13 16:15:14 UTC) #2

ngeoffray

9 years, 2 months ago (2011-10-13 16:16:41 UTC) #3

Thanks,

http://codereview.chromium.org/8276005/diff/1/compiler/lib/implementation/arr...
File compiler/lib/implementation/array.dart (right):

http://codereview.chromium.org/8276005/diff/1/compiler/lib/implementation/arr...
compiler/lib/implementation/array.dart:194: return new List<T>.fromList(this,
start, start + length);
On 2011/10/13 16:15:14, floitsch wrote:
> We should really think of unifying the API.
> [start, length] here, but [start, end] there?

Yes, after the range methods have been implemented, I will clean up the
Array/List mess.

Expand Messages | Collapse Messages

Issue 8276005: Implement List.getRange. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages