Issue 8275036: Fling: implement the new DartCompilerListener.unitCompiled() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8275036: Fling: implement the new DartCompilerListener.unitCompiled() method. (Closed)

Created:
9 years, 2 months ago by fmalita_google_do_not_use

Modified:
9 years, 2 months ago

Reviewers:
codefu, Kelly Norton

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fling: implement the new DartCompilerListener.unitCompiled() method. R=knorton@google.com,codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=441

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	client/fling/src/java/core/com/google/dart/CompileService.java	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

codefu

On 2011/10/14 14:31:37, fmalita wrote: LGTM. I must not have your source mapped in, otherwise ...

9 years, 2 months ago (2011-10-14 14:36:56 UTC) #2

fmalita_google_do_not_use

9 years, 2 months ago (2011-10-14 14:51:02 UTC) #3

r441

On 2011/10/14 14:36:56, codefu wrote:
> LGTM.  I must not have your source mapped in, otherwise I would have covered
> your listeners.  Sorry about that.

No worries, we should probably add some fling tests to catch breakages.

Expand Messages | Collapse Messages