Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 8273035: Add short read/write testing of Socket and Process tests (Closed)

Created:
9 years, 2 months ago by Søren Gjesse
Modified:
9 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add short read/write testing of Socket and Process tests The changes to standalone tests from http://codereview.chromium.org/8226016/ somehow got lost when the tests where moved from runtime/tests/dart to tests/standalone. Also fix and issue where just specifying "VMOptions=" did not run the test without any arguments. R=ngeoffray@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -47 lines) Patch
M tests/standalone/src/EchoServerStreamReadUntilTest.dart View 2 chunks +13 lines, -3 lines 0 comments Download
M tests/standalone/src/EchoServerStreamTest.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/src/EchoServerTest.dart View 5 chunks +36 lines, -42 lines 0 comments Download
M tests/standalone/src/ProcessStderrTest.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/src/ProcessStdoutTest.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/utils.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years, 2 months ago (2011-10-14 09:19:59 UTC) #1
ngeoffray
9 years, 2 months ago (2011-10-14 09:28:41 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698