Issue 8273004: Implement removeRange, and update some documentation on the list interface.

Issue 8273004: Implement removeRange, and update some documentation on the list interface. (Closed)

Created:
9 years, 2 months ago by ngeoffray

Modified:
9 years, 2 months ago

Reviewers:
Anton Muhin, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Implement removeRange, and update some documentation on the list interface. Committed: https://code.google.com/p/dart/source/detail?r=400

Patch Set 2 : '' #

Total comments: 5

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -26 lines)			Patch
M	compiler/lib/implementation/array.dart	View		2 chunks	+28 lines, -1 line	5 comments	Download
M	compiler/lib/implementation/array.js	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	corelib/src/list.dart	View	1	4 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/lib/array.dart	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	1 chunk	+19 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+6 lines, -5 lines	0 comments	Download
A +	tests/corelib/src/ConstListRemoveRangeTest.dart	View		1 chunk	+3 lines, -11 lines	0 comments	Download
A	tests/corelib/src/ListRemoveRangeTest.dart	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	tests/corelib/src/ListSetRangeTest.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

DBQ http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/array.dart File compiler/lib/implementation/array.dart (right): http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/array.dart#newcode154 compiler/lib/implementation/array.dart:154: if (_isFixed) { may we have this in ...

9 years, 2 months ago (2011-10-18 07:44:20 UTC) #3

ngeoffray

http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/array.dart File compiler/lib/implementation/array.dart (right): http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/array.dart#newcode154 compiler/lib/implementation/array.dart:154: if (_isFixed) { On 2011/10/18 07:44:20, antonmuhin wrote: > ...

9 years, 2 months ago (2011-10-18 07:46:09 UTC) #4

Anton Muhin

9 years, 2 months ago (2011-10-18 08:54:45 UTC) #5

ngeoffray

9 years, 2 months ago (2011-10-18 08:58:01 UTC) #6

Anton Muhin

9 years, 2 months ago (2011-10-18 14:33:49 UTC) #7

http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/...
File compiler/lib/implementation/array.dart (right):

http://codereview.chromium.org/8273004/diff/3001/compiler/lib/implementation/...
compiler/lib/implementation/array.dart:154: if (_isFixed) {
I believe yes, but didn't double check.  Anyway, let's see how it will turn out,
we can always refactor later.

On 2011/10/18 08:58:01, ngeoffray wrote:
> On 2011/10/18 08:54:46, antonmuhin wrote:
> > Sorry, I meant the whole logic of methods.  Even for removeRange we can pass
> > _splice.
> > 
> > On 2011/10/18 07:46:09, ngeoffray wrote:
> > > On 2011/10/18 07:44:20, antonmuhin wrote:
> > > > may we have this in Arrays?  Ditto for removeRange.
> > > 
> > > There is a 'rangeCheck' method in Arrays.
> > 
> 
> The _splice is really tight to the implementation, I'm not sure we want to
share
> that. Must your arrays support removeRange or insertRange?

Expand Messages | Collapse Messages