Issue 8270001: Fix the handling of exceptions from process start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8270001: Fix the handling of exceptions from process start (Closed)

Created:
9 years, 2 months ago by Søren Gjesse

Modified:
9 years, 2 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix the handling of exceptions from process start The privious change in r389 where the sockets used to communicate with the chile process did not work. Even though the Socket objects are not assigned any file descriptor they should still have their Dart port closed. If not the VM will not terminate. TBR=ager@google.com TEST=ProcessStartExceptionTest.dart BUG=none Committed: https://code.google.com/p/dart/source/detail?r=395

Patch Set 1 #

Patch Set 2 : Removed print #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	runtime/bin/process_impl.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	runtime/bin/socket_impl.dart	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages