Issue 8261009: Create a standalone test directory and move tests in runtime/tests/dart (mostly) to that directory.

Issue 8261009: Create a standalone test directory and move tests in runtime/tests/dart (mostly) to that directory. (Closed)

Created:
9 years, 2 months ago by ngeoffray

Modified:
9 years, 2 months ago

Reviewers:
iposva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Create a standalone test directory and move tests in runtime/tests/dart (mostly) to that directory. Committed: https://code.google.com/p/dart/source/detail?r=393

Patch Set 1 #

Total comments: 3

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -1 line)			Patch
M	dart/tests/corelib/corelib.status	View	2 chunks	+2 lines, -1 line	0 comments	Download
A +	dart/tests/corelib/src/BigIntegerVMTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	dart/tests/corelib/src/GrowableObjectArray2VMTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	dart/tests/corelib/src/GrowableObjectArrayVMTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	dart/tests/corelib/src/StringBaseVMTest.dart	View	0 chunks	+-1 lines, --1 lines	3 comments	Download
M +	dart/tests/standalone/src/FileInputStreamTest.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M +	dart/tests/standalone/src/ManyEchoServerTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	dart/tests/standalone/standalone.status	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	dart/tests/standalone/testcfg.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	dart/tools/test.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Even though rietveld does not show all files, they have been moved.

9 years, 2 months ago (2011-10-13 12:31:53 UTC) #1

Ivan Posva

http://codereview.chromium.org/8261009/diff/1/dart/tests/corelib/src/StringBaseVMTest.dart File dart/tests/corelib/src/StringBaseVMTest.dart (right): http://codereview.chromium.org/8261009/diff/1/dart/tests/corelib/src/StringBaseVMTest.dart#newcode6 dart/tests/corelib/src/StringBaseVMTest.dart:6: // VMOptions=--expose_core_impl Do we still need this VM option?

9 years, 2 months ago (2011-10-13 12:35:35 UTC) #2

ngeoffray

9 years, 2 months ago (2011-10-13 12:36:28 UTC) #3

Ivan Posva

9 years, 2 months ago (2011-10-13 12:40:23 UTC) #4

LGTM -ip

http://codereview.chromium.org/8261009/diff/1/dart/tests/corelib/src/StringBa...
File dart/tests/corelib/src/StringBaseVMTest.dart (right):

http://codereview.chromium.org/8261009/diff/1/dart/tests/corelib/src/StringBa...
dart/tests/corelib/src/StringBaseVMTest.dart:6: // VMOptions=--expose_core_impl
Ok, I see. We will need to fix this.

On 2011/10/13 12:36:28, ngeoffray wrote:
> On 2011/10/13 12:35:35, Ivan Posva wrote:
> > Do we still need this VM option?
> 
> Right now it's only useful to disable privacy.

Expand Messages | Collapse Messages