Addresses Python style issues in test_configuration.py and test_case.py

Addresses Python style issues in test_configuration.py and test_case.py

Committed: https://code.google.com/p/dart/source/detail?r=390

[zundel, 2011-10-13 00:51:03]

This is the last of the style only changes.  

Next I'm going to focus on uniting the code for threading and make it live in
test_runner.py as well as getting the BrowserTestCases to run in batch mode.

[ahe, 2011-10-13 07:54:37]

LGTM!

[ngeoffray, 2011-10-13 08:03:38]

LGTM! And thanks for doing this.

Small comments, but feel free to ignore if you disagree.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:19: """A test case defined by a .dart file."""
Maybe say a *Test.dart file. But feel free to ignore if you disagree.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:57: """Multiple test cases defined within a single
.dart file."""
ditto

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:69: """Returns True if this is a negative test
(should return FAIL)."""
The comment is parenthesis is confusing, I would put it elsewhere. Maybe where
we check on the test output? Or leave it it but extand it, like:

"""Returns True if this is a negative test. A negative test passes if its output
is FAIL."""

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
File tools/testing/test_configuration.py (right):

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:28: """Configuration that looks for .dart
files in the tests/*/src dirs."""
*Test.dart?

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:85: """Searches for .dart files that qualify
and returns list of TestCases."""
ditto

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:104: """Returns True if the file name looks
like a test file."""
looks like -> is?

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:108: """Populates the sections and defs
parameters if the file exists."""
Change to """Reads the status file of the test suite."""?

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:202: """Searches for .dart files that
qualify and returns list of TestCases."""
*Test.dart

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:232: """Searches for .dart files that
qualify and returns list of TestCases."""
*Test.dart

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:264: """Returns True if name looks like a
test case to be compiled."""
looks like -> is

[zundel, 2011-10-13 11:07:43]

r390, Thanks for the review!

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py
File tools/testing/test_case.py (right):

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:19: """A test case defined by a .dart file."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> Maybe say a *Test.dart file. But feel free to ignore if you disagree.

SGTM, Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:57: """Multiple test cases defined within a single
.dart file."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> ditto

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_case.py#n...
tools/testing/test_case.py:69: """Returns True if this is a negative test
(should return FAIL)."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> The comment is parenthesis is confusing, I would put it elsewhere. Maybe where
> we check on the test output? Or leave it it but extand it, like:
> 
> """Returns True if this is a negative test. A negative test passes if its
output
> is FAIL."""

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
File tools/testing/test_configuration.py (right):

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:28: """Configuration that looks for .dart
files in the tests/*/src dirs."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> *Test.dart?

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:85: """Searches for .dart files that qualify
and returns list of TestCases."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> ditto

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:104: """Returns True if the file name looks
like a test file."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> looks like -> is?

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:108: """Populates the sections and defs
parameters if the file exists."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> Change to """Reads the status file of the test suite."""?

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:202: """Searches for .dart files that
qualify and returns list of TestCases."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> *Test.dart

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:232: """Searches for .dart files that
qualify and returns list of TestCases."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> *Test.dart

Done.

http://codereview.chromium.org/8260004/diff/1003/tools/testing/test_configura...
tools/testing/test_configuration.py:264: """Returns True if name looks like a
test case to be compiled."""
On 2011/10/13 08:03:38, ngeoffray wrote:
> looks like -> is

Done.