Issue 8247014: Changes to handle unresolved qualified identifiers.

Issue 8247014: Changes to handle unresolved qualified identifiers. (Closed)

Created:
9 years, 2 months ago by siva

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Changes to handle unresolved qualified identifiers. Committed: https://code.google.com/p/dart/source/detail?r=411

Patch Set 6 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+457 lines, -39 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1 2 3 4 5	3 chunks	+58 lines, -6 lines	0 comments	Download
M	runtime/vm/class_finalizer_test.cc	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5	6 chunks	+34 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5	11 chunks	+77 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5	8 chunks	+37 lines, -19 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4 5	3 chunks	+15 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3 4 5	1 chunk	+45 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix13NegativeTest.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix14NegativeTest.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix14Test.dart	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix15NegativeTest.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix15Test.dart	View	1 2	1 chunk	+43 lines, -0 lines	0 comments	Download
A	tests/language/src/Prefix16NegativeTest.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/language/src/library12.dart	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM!! http://codereview.chromium.org/8247014/diff/8020/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): http://codereview.chromium.org/8247014/diff/8020/runtime/vm/class_finalizer.cc#newcode316 runtime/vm/class_finalizer.cc:316: lib ^= cls.library(); No downcast necessary. lib = ...

9 years, 2 months ago (2011-10-13 17:23:02 UTC) #2

siva

9 years, 2 months ago (2011-10-13 20:06:39 UTC) #3

http://codereview.chromium.org/8247014/diff/8020/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

http://codereview.chromium.org/8247014/diff/8020/runtime/vm/class_finalizer.c...
runtime/vm/class_finalizer.cc:316: lib ^= cls.library();
On 2011/10/13 17:23:03, regis wrote:
> No downcast necessary.
> lib = instead of lib ^=

Done.

http://codereview.chromium.org/8247014/diff/8020/runtime/vm/class_finalizer.c...
runtime/vm/class_finalizer.cc:327: lib ^= lib_prefix.library();
On 2011/10/13 17:23:03, regis wrote:
> ditto

Done.

http://codereview.chromium.org/8247014/diff/8020/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8247014/diff/8020/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:6066: }
Good idea, Done.

On 2011/10/13 17:23:03, regis wrote:
> Why not move the creation of the unresolved class object to LookupTypeClass?
> LookupTypeClass should not return a raw String anymore.

Expand Messages | Collapse Messages