Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 8247013: Add negative test for detecting error when the same library is imported twice. (Closed)

Created:
9 years, 2 months ago by siva
Modified:
9 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add negative test for detecting error when the same library is imported twice. Committed: https://code.google.com/p/dart/source/detail?r=410

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M tests/language/language.status View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A tests/language/src/Library1NegativeTest.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A tests/language/src/library2.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
9 years, 2 months ago (2011-10-13 00:40:11 UTC) #1
hausner
LGTM.
9 years, 2 months ago (2011-10-13 02:12:53 UTC) #2
hausner
Actually, I don't see Prefix14Test and Prefix15Test in the repo. Did you mean to add ...
9 years, 2 months ago (2011-10-13 02:18:33 UTC) #3
siva
9 years, 2 months ago (2011-10-13 16:59:37 UTC) #4
The prefix14Test.dart and Prefix15Test.dart files are in another CL. I tried
those tests with dartc and they fail.
Since I was updating the status file I decided to add them too.

Powered by Google App Engine
This is Rietveld 408576698