Clean up directory listing interface.

Clean up directory listing interface.

Remove open and close. A directory instance just holds a string
representing the path to the directory.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=362

[Søren Gjesse, 2011-10-12 09:30:30]

lgtm

http://codereview.chromium.org/8244001/diff/1/runtime/bin/directory.dart
File runtime/bin/directory.dart (right):

http://codereview.chromium.org/8244001/diff/1/runtime/bin/directory.dart#newc...
runtime/bin/directory.dart:40: * the listing operation completed.
What does "not completed" actually mean? Will the first error trigger done? Will
recurse continue even if some sub-directories cannot be opened?

[Mads Ager (google), 2011-10-12 10:36:28]

http://codereview.chromium.org/8244001/diff/1/runtime/bin/directory.dart
File runtime/bin/directory.dart (right):

http://codereview.chromium.org/8244001/diff/1/runtime/bin/directory.dart#newc...
runtime/bin/directory.dart:40: * the listing operation completed.
On 2011/10/12 09:30:30, Søren Gjesse wrote:
> What does "not completed" actually mean? Will the first error trigger done?
Will
> recurse continue even if some sub-directories cannot be opened?

Good question. :)

Currently, done means that no errors that could effect the list of files and
directories occurred. Therefore, the listing is done and it completed (so you
got all the callbacks for everything that was encountered). If, for instance, we
found a directory that could not be opened, we don't list the contents of that
directory and completed will be false.