Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Issue 8241013: Pull "$instanceOf" methods off of the native object. No change in behavior. (Closed)

Created:
9 years, 2 months ago by John Lenz
Modified:
9 years, 2 months ago
Reviewers:
jat
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pull "$instanceOf" methods off of the native object. No change in behavior. Committed: https://code.google.com/p/dart/source/detail?r=371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -46 lines) Patch
M compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java View 8 chunks +13 lines, -16 lines 0 comments Download
M compiler/lib/implementation/bool.js View 1 chunk +1 line, -8 lines 0 comments Download
M compiler/lib/implementation/number.js View 1 chunk +0 lines, -8 lines 0 comments Download
M compiler/lib/implementation/object.js View 1 chunk +1 line, -3 lines 0 comments Download
M compiler/lib/implementation/rtt.js View 1 chunk +24 lines, -0 lines 0 comments Download
M compiler/lib/implementation/string.js View 4 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Lenz
9 years, 2 months ago (2011-10-12 17:39:15 UTC) #1
jat
9 years, 2 months ago (2011-10-12 18:08:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698