Refactors some helper functions in ResolverTest back down to ResolverTestCase

Refactors some helper functions in ResolverTest back down to ResolverTestCase 

I intend to make a new test for exercising compile time constants and
want to use the same infrastructure.

Committed: https://code.google.com/p/dart/source/detail?r=382

[zundel, 2011-10-12 17:51:10]

I want to use these convenience methods defined in ResolverTest in another test,
so I pushed them down to ResolverTestCase, which I will use as a base class.  At
the same time, I simplified the test so that you could do it with a single
method call.

http://codereview.chromium.org/8241008/diff/1003/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(left):

http://codereview.chromium.org/8241008/diff/1003/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:681:
private static DartUnit makeUnit(DartNode... topLevelElements) {
Moved all of this into ResolverTestCase

[zundel, 2011-10-12 21:25:28]

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(left):

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:681:
private static DartUnit makeUnit(DartNode... topLevelElements) {
This stuff moved into ResolverTestCase so the logic could be shared in other
subclasses of ResolverTestCase.

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:197:
resolveAndTest(Joiner.on("\n").join(
most of the tests need to simply pass a block of source and list of expected
errors, so I consolidated that use case into one method call.

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java
(right):

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java:111:
ClassElement boolElement = Elements.classNamed("bool");
these extra settings are used by Compile time constant testing not included in
this patch.

[jbrosenberg, 2011-10-12 21:43:38]

LGTM w/1 small Q

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java
(left):

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java:169:
public InterfaceType getNumType() {
Did you mean to remove this one?

[zundel, 2011-10-13 00:45:38]

r382

Thanks for the review!

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java
(left):

http://codereview.chromium.org/8241008/diff/4001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java:169:
public InterfaceType getNumType() {
On 2011/10/12 21:43:38, jbrosenberg wrote:
> Did you mean to remove this one?

Its still hanging around.  I replaced the body with return numType; and moved it
to be by int and double.