Issue 8240005: Handle bug 5442338: PCDescriptors generated wrongly, disallowing optimizations, causing assert fa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8240005: Handle bug 5442338: PCDescriptors generated wrongly, disallowing optimizations, causing assert fa... (Closed)

Created:
9 years, 2 months ago by srdjan

Modified:
9 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Handle bug 5442338: PCDescriptors generated wrongly, disallowing optimizations, causing assert failures in debug. Fixed also assembly code generation in optimized code (a jumbo could be far). The test code from bug 5442338 can run now successfully. Committed: https://code.google.com/p/dart/source/detail?r=376

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	runtime/vm/code_generator.cc	View		1 chunk	+13 lines, -9 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

srdjan

This is a temporary fix for bad PC descriptors generation: resets invocation counter. The proper ...

9 years, 2 months ago (2011-10-12 15:06:30 UTC) #1

lgtm

Expand Messages | Collapse Messages