Issue 8234029: Cleans up style problems in architecture.py and test_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8234029: Cleans up style problems in architecture.py and test_runner.py (Closed)

Created:
9 years, 2 months ago by zundel

Modified:
9 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Nigel Tao, Siggi Cherem (dart-lang)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Cleans up style problems in architecture.py and test_runner.py Cleaning these up so I can merge in changes related to including chromium tests into the mainline test.py. Committed: https://code.google.com/p/dart/source/detail?r=365

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+257 lines, -165 lines)			Patch
M	tools/test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/architecture.py	View	16 chunks	+153 lines, -95 lines	0 comments	Download
M	tools/testing/test_runner.py	View	16 chunks	+94 lines, -69 lines	2 comments	Download
M	tools/utils.py	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! http://codereview.chromium.org/8234029/diff/1/tools/testing/test_runner.py File tools/testing/test_runner.py (right): http://codereview.chromium.org/8234029/diff/1/tools/testing/test_runner.py#newcode149 tools/testing/test_runner.py:149: """Some weird Windows stuff you just have to ...

9 years, 2 months ago (2011-10-12 12:14:11 UTC) #3

zundel

9 years, 2 months ago (2011-10-12 14:13:49 UTC) #4

r365

Thanks for the review.

http://codereview.chromium.org/8234029/diff/1/tools/testing/test_runner.py
File tools/testing/test_runner.py (right):

http://codereview.chromium.org/8234029/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:149: """Some weird Windows stuff you just have to
do."""
On 2011/10/12 12:14:11, ahe wrote:
> :-)

I see you didn't sleep through this review!

Expand Messages | Collapse Messages