Issue 8234022: Implement index operator super call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8234022: Implement index operator super call (Closed)

Created:
9 years, 2 months ago by hausner

Modified:
9 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Implement index operator super call Last portion of super operator calls. Committed: https://code.google.com/p/dart/source/detail?r=359

Patch Set 3 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -32 lines)			Patch
runtime/vm/parser.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
runtime/vm/parser.cc	View	1 2	2 chunks	+84 lines, -29 lines	0 comments	Download
tests/language/src/SuperOperatorTest.dart	View	1 2	1 chunk	+35 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8234022/diff/1004/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/8234022/diff/1004/runtime/vm/parser.cc#newcode1006 runtime/vm/parser.cc:1006: const String& name) { indentation

9 years, 2 months ago (2011-10-11 23:43:10 UTC) #2

hausner

9 years, 2 months ago (2011-10-11 23:50:23 UTC) #3

Thank you!

http://codereview.chromium.org/8234022/diff/1004/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8234022/diff/1004/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1006: const String& name) {
On 2011/10/11 23:43:10, regis wrote:
> indentation

Done.

Expand Messages | Collapse Messages

Issue 8234022: Implement index operator super call (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages