Issue 8232005: Use isolates for directory listing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8232005: Use isolates for directory listing. (Closed)

Created:
9 years, 2 months ago by Mads Ager (google)

Modified:
9 years, 2 months ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Use isolates for directory listing. Use isolates to make directory listing asynchroneous from the point of view of the main Dart isolate. Each listing operation will spawn a new heavy isolate to perform the actually directory listing using the synchroneous OS primitives. R=sgjesse@google.com,iposva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=327

Patch Set 1 #

Patch Set 2 : Remove the TODO comment #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
	M	runtime/bin/directory_impl.dart	View	1	4 chunks	+39 lines, -15 lines	2 comments	Download
	M	runtime/tests/dart/src/DirectoryTest.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm That was simple! http://codereview.chromium.org/8232005/diff/3001/runtime/bin/directory_impl.dart File runtime/bin/directory_impl.dart (right): http://codereview.chromium.org/8232005/diff/3001/runtime/bin/directory_impl.dart#newcode14 runtime/bin/directory_impl.dart:14: _DirectoryListingIsolate() : super.heavy(); "super heavy" ...

9 years, 2 months ago (2011-10-11 13:10:29 UTC) #2

Mads Ager (google)

9 years, 2 months ago (2011-10-11 13:11:42 UTC) #3

http://codereview.chromium.org/8232005/diff/3001/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/8232005/diff/3001/runtime/bin/directory_impl.d...
runtime/bin/directory_impl.dart:14: _DirectoryListingIsolate() : super.heavy();
On 2011/10/11 13:10:30, Søren Gjesse wrote:
> "super heavy" sounds expensive :-)

It does. Let's make sure that it isn't. :-)

Expand Messages | Collapse Messages