Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 8229041: Test for named parameter called 'count'. (Closed)

Created:
9 years, 2 months ago by sra1
Modified:
9 years, 2 months ago
Reviewers:
John Lenz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test for named parameter called 'count'. Currently fails on dartc because the optional argument count is put in the same object as the optional arguments. BUG=5447476 TEST= Committed: https://code.google.com/p/dart/source/detail?r=381

Patch Set 1 #

Total comments: 1

Patch Set 2 : x #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/NamedParametersNamedCountTest.dart View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
9 years, 2 months ago (2011-10-12 06:08:04 UTC) #1
John Lenz
9 years, 2 months ago (2011-10-12 14:28:29 UTC) #2
LGTM.  Thanks for doing this.

http://codereview.chromium.org/8229041/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8229041/diff/1/tests/language/language.status#...
tests/language/language.status:84: NamedParametersNamedCountTest: Fail  # Bug
Please file a bug to go along with this.

Powered by Google App Engine
This is Rietveld 408576698