Fix deadlock in process exit handling

Fix deadlock in process exit handling

As glibc allocation routines are not re-entrant avoid calling delete in signal handler.

Instead the message send from the signal handler on process exit contains both the pid and the exit code. The internal _Process object always installs a data handler for the exit message and calls back into C++ to cleanup the resources allocated for running a process.

Changed the ActiveProcess (renamed to ProcessInfo) to form an explicitly linked list.

R=ager@google.com

BUG=dart:1
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=325

[Søren Gjesse, 2011-10-11 10:41:06]

Linux and Mac OS files are identical.

[Mads Ager (google), 2011-10-11 10:50:27]

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process.h
File runtime/bin/process.h (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process.h#newcode30
runtime/bin/process.h:30: // Indicate that he process with the given pid has
exited.
he -> the

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_impl.dart
File runtime/bin/process_impl.dart (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_impl.dar...
runtime/bin/process_impl.dart:57: _processExit(exitPid(buffer));
indentation

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc...
runtime/bin/process_linux.cc:15: #include "bin/set.h"
Do you need set anymore?

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc...
runtime/bin/process_linux.cc:338: RemoveProcess(id);
Don't you need to delete the returned ProcessInfo* here?

[Søren Gjesse, 2011-10-11 11:08:03]

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process.h
File runtime/bin/process.h (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process.h#newcode30
runtime/bin/process.h:30: // Indicate that he process with the given pid has
exited.
On 2011/10/11 10:50:27, Mads Ager wrote:
> he -> the

Done.

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_impl.dart
File runtime/bin/process_impl.dart (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_impl.dar...
runtime/bin/process_impl.dart:57: _processExit(exitPid(buffer));
On 2011/10/11 10:50:27, Mads Ager wrote:
> indentation

Done.

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (right):

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc...
runtime/bin/process_linux.cc:15: #include "bin/set.h"
On 2011/10/11 10:50:27, Mads Ager wrote:
> Do you need set anymore?

No, removed.

http://codereview.chromium.org/8227010/diff/2001/runtime/bin/process_linux.cc...
runtime/bin/process_linux.cc:338: RemoveProcess(id);
On 2011/10/11 10:50:27, Mads Ager wrote:
> Don't you need to delete the returned ProcessInfo* here?

Changed RemoveProcess to delete the ProcessInfo and return void.

[Mads Ager (google), 2011-10-11 11:18:28]

lgtm