Style cleanups for test.py

Style cleanups for test.py

This reformats test.py to have consistent Python style.

Committed: https://code.google.com/p/dart/source/detail?r=353

[zundel, 2011-10-10 23:48:57]

*If you aren't going to have time to look at this soon, let me know - I don't
want it to get out of date!*

There are 2 parts to this cl

1) Move some of the code in test.py to test_runner.py in order to eliminate the
circular import of test.py from test_runner.py  That code I moved without any
other changes.

2) Updates test.py to be consistent with Python style guidelines.  In order to
do this, I did a tiny bit of refactoring, but most of it is just line wrapping,
quote changing, and line wrapping.

I learned a bit more about the code while documenting these methods, but it was
mostly drugery!

[ahe, 2011-10-11 07:55:34]

LGTM. Thank you for doing this!

The new comments are really helpful!

Cheers,
Peter

http://codereview.chromium.org/8223016/diff/1/tools/test.py
File tools/test.py (right):

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode568
tools/test.py:568: def __init__(self, workspace, verbose, os_def, timeout,
I'm not sure what os_def means. Would you mind not abbreviating "def"?

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode975
tools/test.py:975: """Matches a test case with the test prefixes requested on
the cmdline?
? -> .

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1103
tools/test.py:1103: """Confiigures the Python optparse library with the cmdline
for test.py."""
Confiigures -> Configures

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1273
tools/test.py:1273: return (len(o) == 2) and (testing.FAIL in o) and
(testing.OKAY in o)
Add newline.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1299
tools/test.py:1299: # We don't want to end the program.
We should probably improve this. It is a bit of a hack.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1320
tools/test.py:1320: pattern = '^' + self.pattern.replace('*', '.*') + '$'
I think the style guide prefer:
'^%s$' % self.pattern.replace('*', '.*')

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py
File tools/testing/test_runner.py (right):

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:1: #!/usr/bin/env python
I have assumed the changes to this file was copied verbatim from another file.
Did you make any modifications?

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:23: 
Add newline.

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:29: 
Extra line.

[zundel, 2011-10-11 22:45:44]

r353

http://codereview.chromium.org/8223016/diff/1/tools/test.py
File tools/test.py (right):

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode568
tools/test.py:568: def __init__(self, workspace, verbose, os_def, timeout,
On 2011/10/11 07:55:34, ahe wrote:
> I'm not sure what os_def means. Would you mind not abbreviating "def"?

os conflicts with import os, so I renamed it.  I'll rename it again.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode975
tools/test.py:975: """Matches a test case with the test prefixes requested on
the cmdline?
On 2011/10/11 07:55:34, ahe wrote:
> ? -> .

Done.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1103
tools/test.py:1103: """Confiigures the Python optparse library with the cmdline
for test.py."""
On 2011/10/11 07:55:34, ahe wrote:
> Confiigures -> Configures

Done.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1273
tools/test.py:1273: return (len(o) == 2) and (testing.FAIL in o) and
(testing.OKAY in o)
On 2011/10/11 07:55:34, ahe wrote:
> Add newline.

Done.

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1299
tools/test.py:1299: # We don't want to end the program.
On 2011/10/11 07:55:34, ahe wrote:
> We should probably improve this. It is a bit of a hack.

Added TODO

http://codereview.chromium.org/8223016/diff/1/tools/test.py#newcode1320
tools/test.py:1320: pattern = '^' + self.pattern.replace('*', '.*') + '$'
On 2011/10/11 07:55:34, ahe wrote:
> I think the style guide prefer:
> '^%s$' % self.pattern.replace('*', '.*')

Done.

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py
File tools/testing/test_runner.py (right):

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:1: #!/usr/bin/env python
On 2011/10/11 07:55:34, ahe wrote:
> I have assumed the changes to this file was copied verbatim from another file.
> Did you make any modifications?

Just one.  I held back on making style changes on this file to make the patch
easier to receive.

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:23: 
On 2011/10/11 07:55:34, ahe wrote:
> Add newline.

Done.

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:24: def _CheckedUnlink(name):
I changed this method to start with _ as an indicator it is private to this
file.

http://codereview.chromium.org/8223016/diff/1/tools/testing/test_runner.py#ne...
tools/testing/test_runner.py:29: 
On 2011/10/11 07:55:34, ahe wrote:
> Extra line.

Done.