Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 8222006: Add simple directory listing test. (Closed)

Created:
9 years, 2 months ago by Mads Ager (google)
Modified:
9 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add simple directory listing test. For now, just test that we list something and that no errors occur. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=299

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A runtime/tests/dart/src/DirectoryTest.dart View 1 chunk +40 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
Sorry about the spam. Had to sort out my code review upload settings. Please review ...
9 years, 2 months ago (2011-10-10 14:57:08 UTC) #1
Søren Gjesse
lgtm http://codereview.chromium.org/8222006/diff/1/runtime/tests/dart/src/DirectoryTest.dart File runtime/tests/dart/src/DirectoryTest.dart (right): http://codereview.chromium.org/8222006/diff/1/runtime/tests/dart/src/DirectoryTest.dart#newcode20 runtime/tests/dart/src/DirectoryTest.dart:20: directory.setDoneHandler((completed) { Perhaps format like directory.setDoneHandler( (completed) { ...
9 years, 2 months ago (2011-10-10 14:58:00 UTC) #2
Mads Ager (google)
9 years, 2 months ago (2011-10-10 15:07:37 UTC) #3
http://codereview.chromium.org/8222006/diff/1/runtime/tests/dart/src/Director...
File runtime/tests/dart/src/DirectoryTest.dart (right):

http://codereview.chromium.org/8222006/diff/1/runtime/tests/dart/src/Director...
runtime/tests/dart/src/DirectoryTest.dart:20:
directory.setDoneHandler((completed) {
On 2011/10/10 14:58:00, Soren Gjesse wrote:
> Perhaps format like 
> 
> directory.setDoneHandler(
>     (completed) {
>       ...
>     }

I like the current style better. I find the indentation weird when doing:

directory.setDirHandler(
    (dir) {
      listedSomething = true;
    });

Powered by Google App Engine
This is Rietveld 408576698