Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 8216018: Added DOM MessagePort support. (Closed)

Created:
9 years, 2 months ago by vsm
Modified:
9 years, 2 months ago
Reviewers:
Anton Muhin, antonm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added DOM MessagePort support. Committed: https://code.google.com/p/dart/source/detail?r=329

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -9 lines) Patch
M client/dom/generated/monkey_dom.js View 1 chunk +10 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/MessagePort.dart View 1 chunk +18 lines, -0 lines 1 comment Download
M client/dom/generated/src/wrapping/_MessagePortWrappingImplementation.dart View 1 chunk +60 lines, -1 line 0 comments Download
M client/dom/generated/wrapping_dom.js View 1 chunk +88 lines, -0 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
9 years, 2 months ago (2011-10-10 19:49:33 UTC) #1
Anton Muhin
Change of generated files only :) Seriously, anything changed in not generated part? LGTM http://codereview.chromium.org/8216018/diff/1/client/dom/generated/src/interface/MessagePort.dart ...
9 years, 2 months ago (2011-10-11 11:24:53 UTC) #2
vsm
9 years, 2 months ago (2011-10-11 13:15:34 UTC) #3
Thanks - yes just a regeneration.

Powered by Google App Engine
This is Rietveld 408576698