Turn on d8 interactive debugging before running files passed on the command line

Turn on d8 interactive debugging before running files passed on the command line

If the file test.js contains:

  function f() { debugger; }
  f()

Then running

  $ d8 --debugger test.js

will now hit the breakpoint in f which it would not before.

R=yangguo@chromium.org

BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9366

[Yang, 2011-09-21 13:09:02]

LGTM except for the shared library build.

http://codereview.chromium.org/7981023/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261
src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) {
This breaks the shared library build. Putting this if block into "#ifndef
V8_SHARED [...] #endif" solves this problem.

[Kasper Lund, 2011-09-21 13:14:49]

Nit:

http://codereview.chromium.org/7981023/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257
src/d8.cc:1257: // Keep using the same context in the interactive shell
Terminate comment with .

[Kasper Lund, 2011-09-21 13:16:13]

http://codereview.chromium.org/7981023/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261
src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) {
options.last_run will be true here, right?

[Søren Thygesen Gjesse, 2011-09-21 13:42:50]

http://codereview.chromium.org/7981023/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257
src/d8.cc:1257: // Keep using the same context in the interactive shell
On 2011/09/21 13:14:49, Kasper Lund wrote:
> Terminate comment with .

Done.

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261
src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) {
On 2011/09/21 13:09:02, Yang wrote:
> This breaks the shared library build. Putting this if block into "#ifndef
> V8_SHARED [...] #endif" solves this problem.

Done.

http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261
src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) {
On 2011/09/21 13:16:13, Kasper Lund wrote:
> options.last_run will be true here, right?

Yes, removed check.