Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 7334007: Lower the number of threads for some threading tests when testing on ARM to avoid timeouts (Closed)

Created:
9 years, 5 months ago by Søren Thygesen Gjesse
Modified:
9 years, 5 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Lower the number of threads for some threading tests when testing on ARM to avoid timeouts R=ricow@chromium.org BUG=none TEST=cctest/test-lockers/LockerUnlocker,cctest/test-lockers/LockTwiceAndUnlock,cctest/test-lockers/SeparateIsolatesLocksNonexclusive Committed: http://code.google.com/p/v8/source/detail?r=8597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/cctest/test-lockers.cc View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-11 11:58:33 UTC) #1
Rico
LGTM, is there a reason why this started timing out now?
9 years, 5 months ago (2011-07-11 11:59:56 UTC) #2
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-11 12:16:41 UTC) #3
On 2011/07/11 11:59:56, Rico wrote:
> LGTM, is there a reason why this started timing out now?

Not that I can find. If I run on the tegra2 test boards they also hang with 100
threads before the last push to trunk. I did not mention that in the commit
message, but the tests hang with 100 threads. If they succeed they take less
than 1 sec. On the tegra2 test boards the limit is between 75 and 90 threads.

Powered by Google App Engine
This is Rietveld 408576698