Chromium Code Reviews

Issue 7328013: MIPS: Cleaned up calling-related methods in the assembler. (Closed)

Created:
9 years, 5 months ago by Paul Lind
Modified:
9 years, 5 months ago
Reviewers:
Søren Thygesen Gjesse, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Cleaned up calling-related methods in the assembler. Patterned after r8482, Cleaned up calling-related methods in the ARM assembler. On MIPS I completely refactored the Jump and Call methods. All the Jump and Call macro helpers have been replaced with overloaded functions (matching the ARM version) and using default parameter values where possible. The previously mostly-unused CallSize function is utilized as well (same as on ARM). The unused Jump(Operand, ...) and Call(Operand, ...) versions have been completely removed. I also removed the Jump(BranchDelaySlot, ...) and Call(BranchDelaySlot,...) methods as they were unused and declaring them would either result in a lot of unused code or the previously experienced macro-hell. The only exception to this is for Ret() where the branch delay slot is often used. This fixes the failing debug tests for example cctest test-debug/DebugStepFor. Ported r8482 (41cb9ed) Patch by Daniel Kalmar <kalmard@homejinni.com>; BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8585

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+263 lines, -353 lines)
M src/mips/assembler-mips.h View 1 chunk +7 lines, -2 lines 0 comments
M src/mips/builtins-mips.cc View 2 chunks +2 lines, -3 lines 0 comments
M src/mips/code-stubs-mips.cc View 4 chunks +5 lines, -5 lines 0 comments
M src/mips/full-codegen-mips.cc View 25 chunks +25 lines, -25 lines 0 comments
M src/mips/macro-assembler-mips.h View 3 chunks +31 lines, -75 lines 0 comments
M src/mips/macro-assembler-mips.cc View 8 chunks +191 lines, -241 lines 0 comments
M src/mips/regexp-macro-assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments

Messages

Total messages: 4 (0 generated)
Paul Lind
9 years, 5 months ago (2011-07-08 06:29:28 UTC) #1
Søren Thygesen Gjesse
LGTM
9 years, 5 months ago (2011-07-08 06:57:37 UTC) #2
Sven Panne
LGTM
9 years, 5 months ago (2011-07-08 13:37:47 UTC) #3
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-08 13:51:11 UTC) #4
I will commit it.

Powered by Google App Engine