Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 7324018: MIPS: port Introduce code flushing of RegExp code. (Closed)

Created:
9 years, 5 months ago by Paul Lind
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Introduce code flushing of RegExp code. Ported r8532 (c9db503) Original commit message: Due to issues relating mostly to chrome extensions we have lately been running into OOMs that are caused by our executable space running out. This change introduces flushing of code from regexps if we have not used the code for 5 mark sweeps. The approach is different from the normal function code flusing. Here we make a copy of the code inside the data array, and exchange the original code with a smi determined by the sweep_generation (a new heap variable increased everytime we do mark sweep/compact). If we encounter a smi in EnsureCompiled we simply reinstate the code object. If, in the marking phase of mark sweep, we find a regexp that already have a smi in the code field, and this is more than 5 generations old we flush the code from the saved index. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 5 months ago (2011-07-08 06:28:14 UTC) #1
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-08 06:45:54 UTC) #2
LGTM

I will commit it.

Powered by Google App Engine
This is Rietveld 408576698