Issue 7308001: Correctly handle the constant pool in constant pool splitting test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7308001: Correctly handle the constant pool in constant pool splitting test (Closed)

Created:
9 years, 5 months ago by Søren Thygesen Gjesse

Modified:
9 years, 5 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Correctly handle the constant pool in constant pool splitting test The constant pool was not taken into account in the test test-compiler/SplitConstantsInFullCompiler which caused random failures. This also reverts the test code added in r8469 and r8471. R=ricow@chromium.org BUG=none TEST=test-compiler/SplitConstantsInFullCompiler Committed: http://code.google.com/p/v8/source/detail?r=8520

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	src/arm/disasm-arm.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	test/cctest/test-compiler.cc	View		2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages