Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 7262026: MIPS: port Better codegen for '<expression> === void <literal>'. (Closed)

Created:
9 years, 6 months ago by Paul Lind
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Better codegen for '<expression> === void <literal>'. Ported r8420 (fd2ddbb) Original commit message: Detect the pattern in both, the full compiler and crankshaft and generate direct pointer comparisons. Along the way I cleaned up 'typeof <expression> == <string literal>' comparisons as well by lifting platform independent code and checking the symmetric case. BUG=v8:1440 TEST=cctest/test-api.cc Committed: http://code.google.com/p/v8/source/detail?r=8427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M src/mips/full-codegen-mips.cc View 3 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
9 years, 6 months ago (2011-06-27 00:51:34 UTC) #1
Søren Thygesen Gjesse
LGTM Steven, could you please take a look as well?
9 years, 6 months ago (2011-06-27 08:44:09 UTC) #2
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-27 10:38:46 UTC) #3
I will commit it.

Powered by Google App Engine
This is Rietveld 408576698