Issue 7232004: MIPS: Fix arguments-branch update per review comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7232004: MIPS: Fix arguments-branch update per review comments. (Closed)

Created:
9 years, 6 months ago by Paul Lind

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Karl Klose

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fix arguments-branch update per review comments. This is a follow-on to r8340, http://codereview.chromium.org/7216004/ Søren had commited changes and closed issue, as Karl was commenting about problems in the code. Thanks Karl, for your detailed code review. I have corrected the issues you raised. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8358

Patch Set 1 #

Patch Set 2 : Another v0 -> a0 change. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	src/mips/ic-mips.cc	View	1	4 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 6 months ago (2011-06-22 07:08:13 UTC) #2

LGTM

I will commit it if Karl approves as well.

Expand Messages | Collapse Messages