Issue 7216004: MIPS: port Merge arguments branch to bleeding edge (second try).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7216004: MIPS: port Merge arguments branch to bleeding edge (second try). (Closed)

Created:
9 years, 6 months ago by Paul Lind

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Karl Klose

CC:
v8-dev

Visibility:
Public.

Description

MIPS: port Merge arguments branch to bleeding edge (second try). Ported r8315 (d70d395). BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8340

Patch Set 2 : Fixed some style issues and a trivial optimization. #

Patch Set 3 : Simplify one conditional. #

Total comments: 3

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+444 lines, -111 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	1 2	4 chunks	+257 lines, -24 lines	1 comment	Download
M	src/mips/full-codegen-mips.cc	View		12 chunks	+28 lines, -87 lines	0 comments	Download
M	src/mips/ic-mips.cc	View		1 chunk	+154 lines, -0 lines	2 comments	Download
M	src/mips/stub-cache-mips.cc	View		5 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM I will commit it. http://codereview.chromium.org/7216004/diff/7/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/7216004/diff/7/src/mips/code-stubs-mips.cc#newcode4124 src/mips/code-stubs-mips.cc:4124: __ b(&try_allocate); Is there ...

9 years, 6 months ago (2011-06-21 07:46:40 UTC) #2

Karl Klose

9 years, 6 months ago (2011-06-21 09:26:50 UTC) #4

LGTM when comments are addressed.

http://codereview.chromium.org/7216004/diff/7/src/mips/ic-mips.cc
File src/mips/ic-mips.cc (right):

http://codereview.chromium.org/7216004/diff/7/src/mips/ic-mips.cc#newcode910
src/mips/ic-mips.cc:910: __ And(scratch1, scratch1, Operand(0x8000001));
I think this must be:
__ And(scratch1, key, Operand(0x8000001));

http://codereview.chromium.org/7216004/diff/7/src/mips/ic-mips.cc#newcode976
src/mips/ic-mips.cc:976: //  -- a0     : key
According to the code below the key is in v0, not a0.