Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 7212020: MIPS: port Introduce scopes to keep track of catch blocks at compile time. (Closed)

Created:
9 years, 5 months ago by Paul Lind
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Introduce scopes to keep track of catch blocks at compile time. Port r8496 (b7d5ecf0). Original commit message: Introduce scopes to keep track of catch blocks at compile time. The catch variable is bound in the catch scope. For simplicity in this initial implementation, it is always allocated even if unused and always allocated to a catch context even if it doesn't escape. The presence of catch is no longer treated as a with. In this change, care must be taken to distinguish between the scope where a var declaration is hoisted to and the scope where the initialization occurs. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/mips/full-codegen-mips.cc View 10 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 5 months ago (2011-07-04 04:25:21 UTC) #1
Søren Thygesen Gjesse
9 years, 5 months ago (2011-07-04 09:03:20 UTC) #2
LGTM

I will commit it.

Powered by Google App Engine
This is Rietveld 408576698