Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 7211006: MIPS: Port some DIV changes to BinaryOpStub::GenerateInt32Stub(). (Closed)

Created:
9 years, 6 months ago by Paul Lind
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Port some DIV changes to BinaryOpStub::GenerateInt32Stub(). There were some changes in ARM r8172 that we needed to port to MIPS, but missed. The bug was exposed with the Arm & Mips fix in r8321, "Fix wrong parenthesis in stub ARM and MIPS generation code." BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 6 months ago (2011-06-21 04:39:44 UTC) #1
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-21 07:33:05 UTC) #2
LGTM

I will commit it.

Powered by Google App Engine
This is Rietveld 408576698