Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 7210010: Include the loop header block when eliminating stack checks (Closed)

Created:
9 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 6 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Include the loop header block when eliminating stack checks In simple unconditional loops - like the following - the hydrogen stack check elimination did not detect the call as the loop header block itself was not considered. function f(o) { while(true) { o.a(); } } R=fschneider@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8329

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/hydrogen.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-20 10:38:34 UTC) #1
fschneider
LGTM with the error fixed. http://codereview.chromium.org/7210010/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/7210010/diff/1/src/hydrogen.cc#newcode1255 src/hydrogen.cc:1255: while (instr != NULL ...
9 years, 6 months ago (2011-06-20 12:18:59 UTC) #2
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-20 12:27:48 UTC) #3
http://codereview.chromium.org/7210010/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7210010/diff/1/src/hydrogen.cc#newcode1255
src/hydrogen.cc:1255: while (instr != NULL && !back_edge_dominated_by_call) {
On 2011/06/20 12:18:59, fschneider wrote:
> Should be 
> 
> while (instr != NULL) {

Sorry about that - fixed.

Powered by Google App Engine
This is Rietveld 408576698