Issue 7104083: GYP: Generate makefiles for all architectures on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7104083: GYP: Generate makefiles for all architectures on Linux (Closed)

Created:
9 years, 6 months ago by Søren Thygesen Gjesse

Modified:
9 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

GYP: Generate makefiles for all architectures on Linux On Linux running gyp_v8 will generate makefiles for all architectures. On other platforms generate for ia32 only as that is what is currently supported. The output (out) directory is still shared. R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8246

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -26 lines)			Patch
	M	build/README.txt	View		2 chunks	+17 lines, -24 lines	0 comments	Download
	M	build/gyp_v8	View		5 chunks	+31 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. http://codereview.chromium.org/7104083/diff/1/build/gyp_v8 File build/gyp_v8 (right): http://codereview.chromium.org/7104083/diff/1/build/gyp_v8#newcode147 build/gyp_v8:147: #args.append('--depth=/usr/local/google/home/sgjesse/v8/xxx') is this change intentional?

9 years, 6 months ago (2011-06-09 14:58:04 UTC) #2

Søren Thygesen Gjesse

9 years, 6 months ago (2011-06-09 15:11:41 UTC) #3

http://codereview.chromium.org/7104083/diff/1/build/gyp_v8
File build/gyp_v8 (right):

http://codereview.chromium.org/7104083/diff/1/build/gyp_v8#newcode147
build/gyp_v8:147: #args.append('--depth=/usr/local/google/home/sgjesse/v8/xxx')
On 2011/06/09 14:58:05, jkummerow wrote:
> is this change intentional?

Nope - removed.

Expand Messages | Collapse Messages