Issue 7080052: ARM: Add PostIndex support to Ldrd/Strd macro fallback code....

Issue 7080052: ARM: Add PostIndex support to Ldrd/Strd macro fallback code.... (Closed)

Created:
9 years, 6 months ago by m.m.capewell

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add PostIndex support to Ldrd/Strd macro fallback code. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8380

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
	M	src/arm/assembler-arm.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/arm/macro-assembler-arm.cc	View	1	2 chunks	+39 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM with comments addressed Sorry for the delay - it somehow fell between the cracks. ...

9 years, 6 months ago (2011-06-14 10:44:01 UTC) #2

m.m.capewell

http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#newcode666 src/arm/macro-assembler-arm.cc:666: MemOperand src2(src); On 2011/06/14 10:44:01, Søren Gjesse wrote: > ...

9 years, 6 months ago (2011-06-22 12:42:35 UTC) #3

Søren Thygesen Gjesse

9 years, 6 months ago (2011-06-22 19:21:09 UTC) #4

On 2011/06/22 12:42:35, m.m.capewell wrote:
> http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
> 
>
http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#...
> src/arm/macro-assembler-arm.cc:666: MemOperand src2(src);
> On 2011/06/14 10:44:01, Søren Gjesse wrote:
> > Please move the declaration of src2 closer to where it is used. I suggest
> > declaring it twice just before each src2.set_offset(...), as there is one if
> > branch where it is not used.
> 
> Done.
> 
>
http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#...
> src/arm/macro-assembler-arm.cc:676: } else {  // PostIndex or NegPostIndex.
> On 2011/06/14 10:44:01, Søren Gjesse wrote:
> > Please assert PostIndex or NegPostIndex.
> 
> Done.
> 
>
http://codereview.chromium.org/7080052/diff/1/src/arm/macro-assembler-arm.cc#...
> src/arm/macro-assembler-arm.cc:711: } else {  // PostIndex or NegPostIndex.
> On 2011/06/14 10:44:01, Søren Gjesse wrote:
> > Please assert PostIndex or NegPostIndex.
> 
> Done.

Committed. Thank you for the patch.

Expand Messages | Collapse Messages