Issue 7059015: Platform and build updates for Android build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7059015: Platform and build updates for Android build (Closed)

Created:
9 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Platform and build updates for Android build R=ager@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=8042

Patch Set 2 : Addressed review comments and added some more configuration #

Patch Set 3 : Minor changes #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -1 line)			Patch
	M	tools/gyp/v8.gyp	View	1	3 chunks	+66 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

http://codereview.chromium.org/7059015/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/7059015/diff/1/tools/gyp/v8.gyp#newcode866 tools/gyp/v8.gyp:866: 'v8_base', I don't understand why this should be needed? ...

9 years, 7 months ago (2011-05-23 15:26:26 UTC) #2

Søren Thygesen Gjesse

Added some more configuration, please take another look. http://codereview.chromium.org/7059015/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/7059015/diff/1/tools/gyp/v8.gyp#newcode866 tools/gyp/v8.gyp:866: 'v8_base', ...

9 years, 7 months ago (2011-05-24 13:20:42 UTC) #3

LGTM