Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 7048003: Improve bit tests on IA32. (Closed)

Created:
9 years, 7 months ago by yuqiang.xian%intel.com
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve bit tests on IA32. Bit tests with a memory operand should be avoided on Intel processors. On Atom bts with a memory operand has 10~11 cycles latency and on Core 2 it has 5~6 cycles latency, and also produces multiple uops. If the bit base operand is a register the latency is 1 cycle instead. This CL improves several cases from Kraken 1.1 benchmark on Atom. For example, 12% for imaging-desaturate, 8% for audio-fft, and 5% for audio-beat-detection. Committed: http://code.google.com/p/v8/source/detail?r=7987

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
LGTM with additional comment. http://codereview.chromium.org/7048003/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/7048003/diff/1/src/ia32/macro-assembler-ia32.cc#newcode75 src/ia32/macro-assembler-ia32.cc:75: // Set dirty mark for ...
9 years, 7 months ago (2011-05-23 08:26:17 UTC) #1
yuqiang.xian%intel.com
Comment addressed. Thanks for the review.
9 years, 7 months ago (2011-05-23 08:48:49 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-23 10:47:20 UTC) #3
LGTM

I will commit it.

Powered by Google App Engine
This is Rietveld 408576698