Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 7038002: Submit stub-cache-mips.cc. (Closed)

Created:
9 years, 7 months ago by Paul Lind
Modified:
9 years, 7 months ago
CC:
v8-dev
Base URL:
http://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Submit stub-cache-mips.cc. Compiles, but not testable until all of mips port is in place. It has been tested externally. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3626 lines, -125 lines) Patch
M src/mips/stub-cache-mips.cc View 37 chunks +3626 lines, -125 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
9 years, 7 months ago (2011-05-17 04:43:43 UTC) #1
Søren Thygesen Gjesse
LGTM I will commit it.
9 years, 7 months ago (2011-05-17 07:58:37 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-17 09:19:52 UTC) #3
Btw. a single question. In some cases JumpIfSmi is called with an explicit
scratch register. Is there any reason for doing that - will the default scratch
register at not always be "free"?

Powered by Google App Engine
This is Rietveld 408576698