Issue 7019004: Submit full-codegen-mips.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7019004: Submit full-codegen-mips.cc. (Closed)

Created:
9 years, 7 months ago by Paul Lind

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://github.com/v8/v8.git@bleeding_edge

Visibility:
Public.

Description

Submit full-codegen-mips.cc. Includes an arch-independent change for FullCodeGenerator::Split() prototype for mips, which requires two extra parameters. Compiles, does not run yet. Tested externally. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7906

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3811 lines, -138 lines)			Patch
	M	src/full-codegen.h	View		1 chunk	+9 lines, -0 lines	1 comment	Download
	M	src/mips/full-codegen-mips.cc	View		7 chunks	+3802 lines, -138 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 7 months ago (2011-05-17 10:24:34 UTC) #2

LGTM

I will commit it.

http://codereview.chromium.org/7019004/diff/1/src/full-codegen.h
File src/full-codegen.h (right):

http://codereview.chromium.org/7019004/diff/1/src/full-codegen.h#newcode303
src/full-codegen.h:303: #ifdef V8_TARGET_ARCH_MIPS
We should avoid this type of #ifdef/#endif in architecture independent files. I
will commit it like this, but please make a separate change to get rid of it.

Maybe just remove the condition and implement both on all platforms with one or
the other just having UNREACHABLE(). This is what we have done with the
different Plug functions taking a RootListIndex. On IA32 they are implemented as
UNREACHABLE() as we don't have a root register reserved there.

Expand Messages | Collapse Messages