Issue 7006021: MIPS: port Fix a number of IC stubs to correctly set the call kind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7006021: MIPS: port Fix a number of IC stubs to correctly set the call kind. (Closed)

Created:
9 years, 6 months ago by Paul Lind

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

MIPS: port Fix a number of IC stubs to correctly set the call kind. Ported r8109 (7ab86acc) to mips. Original commit message: Make the call kind and call wrapper arguments explicit to force developers to make a choice. This would have avoided the bug in the first case. BUG= TEST=

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -38 lines)			Patch
M	src/mips/builtins-mips.cc	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips/ic-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	14 chunks	+31 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

I will commit it.

Expand Messages | Collapse Messages