Issue 6966031: MIPS: Update for 23-May commits, and a few older ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6966031: MIPS: Update for 23-May commits, and a few older ones. (Closed)

Created:
9 years, 7 months ago by Paul Lind

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Update for 23-May commits, and a few older ones. Make mips-specifc changes for r7999, r8001, r8002. Also bring in changes for older commits 7203, 7279, 7693, 7715, 7788. Mips changes for 7715 (Arm: Support hardfloat in SCons build), and 7693 (Implement hardfloat calling convention in macro assembler and simulator) resulted in changes to SConstruct. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8022

Patch Set 1 #

Total comments: 3

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+592 lines, -182 lines)			Patch
M	SConstruct	View	4 chunks	+29 lines, -8 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	18 chunks	+105 lines, -74 lines	0 comments	Download
M	src/mips/codegen-mips.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/mips/constants-mips.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/mips/debug-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/frames-mips.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	4 chunks	+6 lines, -8 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	5 chunks	+50 lines, -28 lines	1 comment	Download
M	src/mips/macro-assembler-mips.cc	View	6 chunks	+150 lines, -16 lines	2 comments	Download
M	src/mips/simulator-mips.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View	6 chunks	+179 lines, -29 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 7 months ago (2011-05-24 07:21:00 UTC) #2

LGTM

I will fix the style issues and commit.

http://codereview.chromium.org/6966031/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

http://codereview.chromium.org/6966031/diff/1/src/mips/macro-assembler-mips.c...
src/mips/macro-assembler-mips.cc:215: for (int i = 0; i <
FPURegister::kNumAllocatableRegisters; i+=2) {
Indentation.

http://codereview.chromium.org/6966031/diff/1/src/mips/macro-assembler-mips.c...
src/mips/macro-assembler-mips.cc:222: for (int i = 0; i <
FPURegister::kNumAllocatableRegisters; i+=2) {
Indentation.

http://codereview.chromium.org/6966031/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):

http://codereview.chromium.org/6966031/diff/1/src/mips/macro-assembler-mips.h...
src/mips/macro-assembler-mips.h:212: if (!dst.is(src)) {
Indentation.

Expand Messages | Collapse Messages